Skip to content

STM32: USBDevice files clean-up #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2017

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Aug 28, 2017

Description

Refactor ST USBDevice files to facilitate the maintenance.

Main changes:

  • Only two files are used to differentiate the USB peripheral used in the targets: USBHAL_IP_DEVICE.h and USBHAL_IP_OTGFSHS.h
  • The USB peripheral selection is done in USBHAL_STM32.h
  • Add support of NUCLEO-F401RE, NUCLEO-F411RE, DISCO-F469NI and DISCO-F746NG targets

The USB_1 test has been run successfully on all targets described in USBHAL_STM32.h:

Nucleo-144 boards:
NUCLEO_F207ZG
NUCLEO_F303ZE
NUCLEO_F412ZG
NUCLEO_F429ZI
NUCLEO_F446ZE
NUCLEO_F746ZG
NUCLEO_F767ZI

Nucleo-64 boards:
NUCLEO_F103RB
NUCLEO_F401RE
NUCLEO_F411RE
NUCLEO_F446RE

Discovery boards:
DISCO_F407VG
DISCO_F469NI
DISCO_F746NG
DISCO_F769NI
DISCO_L053C8
DISCO_L072CZ_LRWAN1
DISCO_L475VG_IOT01A
DISCO_L476VG

Status

READY

Migrations

NO

@theotherjimmy
Copy link
Contributor

Just based on the +/- numbers, I would say this is a win so far.

@studavekar
Copy link
Contributor

/morph test

@mbed-bot
Copy link

mbed-bot commented Sep 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1188

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 4, 2017

@bcostm Can you please rebase, will retriger CI and will be good to go.

@bcostm bcostm force-pushed the usbdevice_clean-up branch from c47dd3f to 8f4b6e2 Compare September 5, 2017 12:10
@bcostm
Copy link
Contributor Author

bcostm commented Sep 5, 2017

Rebase done.

@screamerbg
Copy link
Contributor

Bump @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2017

Will be tested once we get in few critical items for 5.6 this week

@theotherjimmy
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1356

Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 22, 2017

/morph test

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1389

Build failed!

@studavekar
Copy link
Contributor

The failure from tools error msg says "No space left on device" but looks like we have lot of free space on system.

00:00:47.546 ('Replacing modulTraceback (most recent call last):
00:00:48.102   File "C:\mj\workspace\bm_wrap\1497\mbed-os\tools\test.py", line 225, in <module>
00:00:48.102     stats_depth=options.stats_depth)
00:00:48.102   File "C:\mj\workspace\bm_wrap\1497\mbed-os\tools\test_api.py", line 2226, in build_tests
00:00:48.103     print report[target_name][toolchain_name][test_key][0][0]['output'].rstrip()
00:00:48.103 IOError: [Errno 28] No space left on device
00:00:48.103 [ERROR] [Errno 28] No space left on device

image

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1392

All builds and test passed!

@theotherjimmy theotherjimmy merged commit b562e4e into ARMmbed:master Sep 27, 2017
@bcostm bcostm deleted the usbdevice_clean-up branch October 2, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants